Build-info file's solc output has contracts with absolute paths

[ericglau]

Component

Forge

Have you ensured that all of these are up to date?

• Foundry
• Foundryup

What version of Foundry are you on?

forge 0.2.0 (2e3c197 2024-05-06T16:01:48.856025000Z)

What command(s) is the bug in?

forge build --build-info

Operating System

macOS (Apple Silicon)

Describe the bug

Recent versions of forge causes solc output's contracts paths to use absolute paths, whereas previously they were paths relative to the project root.

For example, run:

forge init
forge build --build-info

In out/build-info/<file>.json, the input section has sources with paths relative to the project root, e.g.:

  "input": {
    "language": "Solidity",
    "sources": {
      "lib/forge-std/src/Base.sol": {
...

However in the output section, contracts have absolute paths.

  "output": {
    "contracts": {
      "/Users/MyUser/foundryproject/lib/forge-std/src/Base.sol": {

This causes a problem for any tooling which tries to match output contracts with their corresponding source inputs.

[ualtinok]

I've encountered this problem while trying to use openzeppelin-foundry-upgrades. It causes to fail with:

[FAIL. Reason: setup failed: revert: Failed to run upgrade safety validation: /...../node_modules/@openzeppelin/upgrades-core/dist/validate/run.js:152
        const content = solcInput.sources[source].content;
                                                  ^

TypeError: Cannot read properties of undefined (reading 'content')

[mattsse]

thanks for flagging

@klkvr perhaps this was caused by recent changes in compilers

[0xalpharush]

From crytic/slither-action#84 (comment)

If you have the option, installing an older Foundry release seems to work around the problem: foundryup -v nightly-f625d0fa7c51e65b4bf1e8f7931cd1c6e2e285e9

Maybe something related to the addition of SparseOutputFileFilter or the conflict_free_output_file in foundry-compilers that was pulled in by #7822

[mattsse]

ah I see what happened, we changed the order in which build info is computed and base path gets attached again @klkvr

https://github.com/foundry-rs/compilers/blob/b16faac372bde7d74784ef3ec69f688be68e79ae/src/compile/project.rs#L695-L696

https://github.com/foundry-rs/compilers/blob/b16faac372bde7d74784ef3ec69f688be68e79ae/src/compile/project.rs#L569-L576

this now happens after:

https://github.com/foundry-rs/compilers/blob/b16faac372bde7d74784ef3ec69f688be68e79ae/src/compilers/solc/mod.rs#L45-L47

@klkvr I believe this can be fixed by doing the join part separately