-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Acquire collection loader #935
base: main
Are you sure you want to change the base?
Conversation
First of all, thanks for you contribution @Matthijsy. I think this is a good first attempt :)! As you kind of pointed out, the Let me know what you think about this! |
dissect/target/loaders/zip.py
Outdated
@@ -0,0 +1,97 @@ | |||
import logging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add tests for this new functionality? This could be done later, if you decide to go on the AcquireLoader
route.
@Horofic Thank you for the feedback, that indeed sounds like a good plan. I have now changed it to a dedicated
I suspect that the Furthermore, I suspect this will not work anymore for the legacy acquire format as described in the |
Posting this comment for documentation purposes. @Matthijsy and I had a discussion outside of this PR regarding possible approaches for this @Matthijsy one possible approach we haven’t gone over is described and implemented in PR #700 by @Zawadidone. I believe some changes have to be made to the current |
This PR adds a loader for ZIP files, which is mainly useful for ZIP based acquire collects.
I don't have experience with creating loaders, and mainly took the logic from the TarLoader. So if there are things that can be done better would be happy to improve!
fixes #934