Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why use compositonSpecification.xml to specify modules? #143

Open
Maoyuxing opened this issue Dec 10, 2016 · 1 comment
Open

Why use compositonSpecification.xml to specify modules? #143

Maoyuxing opened this issue Dec 10, 2016 · 1 comment

Comments

@Maoyuxing
Copy link

Hi, I read your code and I found that you use a thread in CompositionManager class to wait for modules specified in xml files to connect. If time threshold expires, an error will be thrown. What's the point in doing this? If the core accepts all the modules running on the backends and does not waiting for specified modules, will there be any troubles? Thank you!

@schwabe
Copy link
Contributor

schwabe commented Dec 12, 2016

The timeout was/is intended to have some other action, e.g. notifying some manager to restart/check the modules, altought without that being implemented the timeout feels ood, I agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants