Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dockerize #7

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Dockerize #7

wants to merge 1 commit into from

Conversation

fpopic
Copy link
Owner

@fpopic fpopic commented Oct 31, 2023 •
edited
Loading

Fixes #3

TODO

  • Add CI that build docker image and pushes to a registry
  • Add repo versioning with git tag
  • Update Readme

@fpopic fpopic changed the title (#3) Dockerize. Dockerize. Oct 31, 2023
@dkorunic
Copy link

Each RUN creates another layer and there is no need to do that. I would recommend using boolean && to merge multiple commands into a single chain that should fail (and short-circuit rest of the execution) in case of an error.

@fpopic
Copy link
Owner Author

fpopic commented Jan 24, 2024

Each RUN creates another layer and there is no need to do that. I would recommend using boolean && to merge multiple commands into a single chain that should fail (and short-circuit rest of the execution) in case of an error.

yes agree, didn't have time to make it work first and then optimize it (split builder from runtime image using multi-staged images and reduce amount of layers). If you wanna take over that task and contribute, feel free :)

@fpopic fpopic changed the title Dockerize. Dockerize Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dockerize everything
2 participants
@fpopic @dkorunic