From 4535cc01e7de2face81ea9d65827988f6d1c3a8a Mon Sep 17 00:00:00 2001 From: Sam Barker Date: Mon, 15 Jul 2024 11:52:34 +1200 Subject: [PATCH] Its a constant so treat it as such Signed-off-by: Sam Barker rh-pre-commit.version: 2.0.1 rh-pre-commit.check-secrets: ENABLED --- .../systemtests/clients/StrimziTestClient.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/kroxylicious-systemtests/src/main/java/io/kroxylicious/systemtests/clients/StrimziTestClient.java b/kroxylicious-systemtests/src/main/java/io/kroxylicious/systemtests/clients/StrimziTestClient.java index 6f1543319c..7ee6d2b5c7 100644 --- a/kroxylicious-systemtests/src/main/java/io/kroxylicious/systemtests/clients/StrimziTestClient.java +++ b/kroxylicious-systemtests/src/main/java/io/kroxylicious/systemtests/clients/StrimziTestClient.java @@ -37,6 +37,7 @@ * The type Strimzi Test client (java client based CLI). */ public class StrimziTestClient implements KafkaClient { + private static final String RECEIVED_MESSAGE_MARKER = "Received message:"; private static final Logger LOGGER = LoggerFactory.getLogger(StrimziTestClient.class); private static final TypeReference VALUE_TYPE_REF = new TypeReference<>() { }; @@ -112,12 +113,10 @@ private List getConsumerRecords(Stream logRecords) { } private Stream extractRecordLinesFromLog(String log) { - String stringToSeek = "Received message:"; - return Stream.of(log.split("\n")) - .filter(l -> l.contains(stringToSeek)) + .filter(l -> l.contains(RECEIVED_MESSAGE_MARKER)) .map(line -> { - final String[] split = line.split(stringToSeek, 2); // Limit is 1 based so a limit of 2 means use the seek at most 1 times + final String[] split = line.split(RECEIVED_MESSAGE_MARKER, 2); // Limit is 1 based so a limit of 2 means use the seek at most 1 times if (split.length > 1) { return split[1]; }