Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorderSiblings method doesn't update softdeleted node's position #255

Open
snekku-dev opened this issue Dec 16, 2022 · 0 comments
Open

Comments

@snekku-dev
Copy link

snekku-dev commented Dec 16, 2022

Hello, I am trying to manage a tree that includes softdeleted nodes and I noticed whenever I update a node's position all the non-softedeleted nodes correctly increment/decrement their position, but the softdeleted nodes do not, causing certain group of nodes to end up with the same position and messing up the order whenever a new position update is made.

The solution that I think would work would be to include trashed nodes in every scope/builder that. Alternatively I would set the method as protected so that I could override it in the extended model

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant