Misleading error message for site commands

[ankush]

Here the error should be "migrat" command not found, click usually gets typos and suggest right one but our site arg modification is probably messing with it.

λ bench --site dev.localhost migrat
Usage: bench [OPTIONS] COMMAND [ARGS]...
Try 'bench --help' for help.

Error: No such option: --site

Related code:

bench/bench/cli.py

Lines 134 to 138 in dcae3e3

	if in_bench:
	if cmd_from_sys in get_frappe_commands():
	frappe_cmd()
	else:
	app_cmd()

If we merge frappe and app commands it kind works, but that will likely break other things.

[gavindsouza]

Something like the following could help probs? (But with additional changes of course - especially replace EXECV usages)

		frappe_commands = get_frappe_commands()
		frappe_command_exists = cmd_from_sys in frappe_commands

		if frappe_command_exists:
			frappe_cmd()

		try:
			app_cmd()
		except Exception:
			from difflib import get_close_matches

			possibilities = get_close_matches(cmd_from_sys, frappe_commands)
			if possibilities:
				raise NoSuchOption(cmd_from_sys, possibilities=possibilities)
			raise

[bosue]

Related and really awful:

Aarggh… 🥵😆

edit: Of course, bench --site ap15 run-tests --app lending does work fine. It‘s just not intuitive at all why some flags weirdly need to be set in front of the actual command whereas others have to go to the end.

[ankush]

#1542

This fixes the problem, MILDLY breaking but I doubt anyone uses internal get-frappe-commands via bench API. So eh. 🤷

> bench --site dev.localhost migrat
Error: No such command 'migrat'.

[ankush]

Wait, the help message is still misleading... little less than before 😆

Try 'bench frappe --help' for help.

We can probably handle error message in Framework.

[ankush]

Overrriding click.Group in Framework works.

[ankush]

@bosue that one is practically unfixable. --site will have to be come first... open to PRs if there's any to fix it.