Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use 127.0.0.1 instead of localhost #1485

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Conversation

ankush
Copy link
Member

@ankush ankush commented Sep 13, 2023

  • fix: nodejs redis v4 interprets localhost as ipv6 address
  • test: fix expected failing tests

repeat of #1466

Not really required but SLIGHTLY faster, so eh.

blaggacao and others added 2 commits September 13, 2023 15:43
But the redis only binds to 127.0.0.1, not ::1.

Avoid this problem by being explicit.
@sonarcloud
Copy link

sonarcloud bot commented Sep 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

@ankush ankush merged commit dcae3e3 into frappe:develop Sep 13, 2023
13 checks passed
@ankush ankush deleted the localhost branch September 13, 2023 11:18
@github-actions
Copy link

🎉 This PR is included in version 5.18.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants