New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ansible): Use include_tasks instead of include #1564

Merged

akhilnarang merged 1 commit into frappe:develop from cogk:fix-use-import_tasks-instead-of-include

Aug 12, 2024

Contributor

cogk commented May 31, 2024 •

edited

Loading

Happens on Ubuntu 24.04 during bench setup production.

https://serverfault.com/questions/875247/whats-the-difference-between-include-tasks-and-import-tasks#comment1143958_875292

ansible/ansible#76684

ERROR! [DEPRECATED]: ansible.builtin.include has been removed. Use include_tasks or import_tasks instead. This feature was removed from ansible-core in a release after 2023-05-16. Please update your playbooks.

The error appears to be in '/usr/local/lib/python3.12/dist-packages/bench/playbooks/roles/mariadb/tasks/main.yml': line 2, column 3, but may
be elsewhere in the file depending on the exact syntax problem.

The offending line appears to be:

---
- include: centos.yml
  ^ here
ERROR: Command '['ansible-playbook', '-c', 'local', 'site.yml', '-vvvv', '-e', '{"production": true, "admin_emails": "", "mysql_root_password": null, "container": false}', '-t', 'fail2ban']' returned non-zero exit status 1.

sonarcloud bot commented May 31, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Member

akhilnarang commented Aug 12, 2024

@cogk could you rebase this since #1563 fixed part of this already


          fix(ansible): Use include_tasks instead of include

cbd703d

cogk force-pushed the fix-use-import_tasks-instead-of-include branch from df5c5d4 to cbd703d Compare

August 12, 2024 09:51

sonarcloud bot commented Aug 12, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

cogk changed the title ~~fix(ansible): Use import_tasks instead of include~~ fix(ansible): Use include_tasks instead of include

akhilnarang merged commit 21b990e into frappe:develop

11 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet