Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [General Question] This Month in dashboard should show summary for currentDate - startDateOfMonth #884

Closed
arunppsg opened this issue Apr 6, 2024 · 0 comments · Fixed by #972
Labels
question Further information is requested

Comments

@arunppsg
Copy link

arunppsg commented Apr 6, 2024

Summary

Currently, when we choose the This Month option in Dashboard, it shows summary between the dates currentDate and currentDate - 1 month. For example, it shows summary between 6-April-2024 and 6-March-2024.

I think This Month should show summary only for the current month as This refers to the current month and not the last one month period. In the above example, it will be summary between 6-April-2024 and 1-April-2024.

I think there are two possible solutions:

  • If we want to show for last 1 month, we could rename the option like 1 Month.
  • We could compute fromDate to use current month's beginning date. In this case, this line will be:
    fromDate = toDate.minus({ months: 1 });

    fromDate = toDate.startOf('month');
@arunppsg arunppsg added the question Further information is requested label Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants