Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide unneeded settings from non-admin users #461

Open
yeskunall opened this issue Dec 7, 2024 · 0 comments
Open

Hide unneeded settings from non-admin users #461

yeskunall opened this issue Dec 7, 2024 · 0 comments

Comments

@yeskunall
Copy link

yeskunall commented Dec 7, 2024

As of now, the current display settings are a bit too lax/permissive. Any and all users with access to FCRM can access Settings > Invite members by default. From a business + security standpoint we cannot allow this in our organization, so we’ve disabled it. But the sales agents can still “send invites”—it simply errors out, but that option should just be hidden if the role doesn’t have permission for it.

All FCRM screenshots taken as a Sales User.

Screenshots

CleanShot 2024-12-06 at 21 42 22@2x CleanShot 2024-12-06 at 21 46 00@2x

From a pure business standpoint, sales users have no need to tweak any ERPNext or integration settings. From a security standpoint, I see no need to show these users this information either. But they can click on these tabs only to be presented with nothing to do in the UI.

Another example

CleanShot 2024-12-06 at 21 35 42@2x

Is there a reason they’re shown in the UI by default?


Thanks for your work on FCRM so far! 💖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant