chore/small refactor

[blaggacao]

• chore: devoid pr of hard to maintain code smells
• feat(payment): add more payment channels than just email and phone (think: chat)
• test: add payment channel tests

^^ on prior PRs part of my current sprint

---

• perf: flush db at once
• refactor: explicate intent on make_payment_request interface

no-docs

[ruthra-kumar]

@blaggacao Do you still need this as #40643 is merged?

[blaggacao]

@ruthra-kumar yes, please, this is a crucial stepping stone for:

• feat: enable a new payment controller #40845 (wip)
• hence: refactor: clarify architecture, implement PayZen & implement Wompi payments#53 (wip)
• thus contributing my PayZen integration (undergoing 3rd iteration, atm)

😄

(I just rebased)

[blaggacao]

@ruthra-kumar it is still green as a package, but you might want to review the feature of #40424 first. That PR also boast of additional test coverage, establishing a new stability baseline. 🤷

[stale]

This pull request has been automatically marked as inactive because it has not had recent activity. It will be closed within 3 days if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

[blaggacao]

Lore ipsum ...

[blaggacao]

Closing this in order to focus on #40845