Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: set status of payment request on 'before_submit' #42000

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

blaggacao
Copy link
Collaborator

Part of #40845

cc @ruthra-kumar

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Jun 23, 2024
@blaggacao
Copy link
Collaborator Author

ping

@blaggacao blaggacao force-pushed the payments/pr-3 branch 2 times, most recently from fd2570d to a24d3e1 Compare June 23, 2024 14:20
@blaggacao blaggacao marked this pull request as ready for review June 24, 2024 16:52
@blaggacao
Copy link
Collaborator Author

@ruthra-kumar this is green now on its own.

@blaggacao
Copy link
Collaborator Author

Go for it now. The future is promised to no one. - Wayne Dyer


Kindly help move this PR forward. Many thanks from Yours Sincerely!

@ruthra-kumar ruthra-kumar self-assigned this Jul 1, 2024
@ruthra-kumar ruthra-kumar merged commit ec9ab6d into frappe:develop Jul 1, 2024
13 checks passed
@ruthra-kumar ruthra-kumar changed the title perf: flush db at once refactor: set status of payment request on 'before_submit' Jul 1, 2024
@blaggacao blaggacao deleted the payments/pr-3 branch July 1, 2024 08:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants