Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new fork, react-dropdown-now #183

Open
iambumblehead opened this issue Dec 27, 2019 · 6 comments
Open

new fork, react-dropdown-now #183

iambumblehead opened this issue Dec 27, 2019 · 6 comments

Comments

@iambumblehead
Copy link

iambumblehead commented Dec 27, 2019

With humble respect to @fraserxu I have published a fork of react-dropdown named react-dropdown-now. The reason for a fork is, this repository seems unmaintained and its sources need updates to remain usable. For example, recent versions of react log noisy messages about react-dropdown's usage of deprecated lifecycle hooks.

I'm interested to further stabilize the forked dropdown and to accept pull requests needed by other users. Small improvements are already found in the react-dropdown-now fork,

  • It uses @GuiSchafer's changes to remove the deprecated lifecycle hook ComponentWillReceiveProps
  • A unit-testing process is added for testing the component using the ava package (only two simple tests as of writing this)
  • Babel and many other packages are updated to the newest version and npm install does not result in audit warnings
  • Misc changes, some eslint rules are added and some script commands are simplified so that it is not necessary to globally install packages (easier development)
@christiansaiki
Copy link

Nice work @iambumblehead

@iambumblehead
Copy link
Author

Thanks, but the important changes there are mostly from @lwhiteley

@iambumblehead
Copy link
Author

A little update on react-dropdown-now,

  • added many more unit tests,
  • added a storybook demo page,
  • added a typescript types file,
  • added react hooks state management,
  • added a build pipeline to auto test and lint all files,
  • added support for custom selection nodes ex, selection one
  • updated classNames to use "rdn"-prefixed classNames,
  • fixed several more bugs

@travisddraper
Copy link

I'm sure I'm misunderstanding something, but I installed this into my react-app and yarn run start no longer worked.
" react-scripts' is not recognized as an internal or external command, operable program or batch file "

@iambumblehead
Copy link
Author

@travisddraper if you make a little package that demonstrates the problem, I'll take a look to try and resolve it.

@iambumblehead
Copy link
Author

@travisddraper react-dropdown-now is updated with changes that may resolve the issue you were having

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants