You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Was looking at the code and I personally would prefer to put up any dispatch outside of the components.
Example here id rather have this as a props passed by the parent container.
The idea is to have UI drawing in components and anything else abstracted into its parent container.
Store Actions are in containers
Views are in components
So in your structure, if u want to change actions, u will be updating the component not the container.. which is counter intuitive.
Besides, it looks like ur container is only a wrapper for redux and then dumps it into the component. Not that useful IMHO :)
Sorry I'm just switching to a new job and don't have enough time for this project. It would be great if you could create a pull request to show your idea and I'm happy to discuss your idea there.
Hey there,
Was looking at the code and I personally would prefer to put up any
dispatch
outside of the components.Example here id rather have this as a props passed by the parent container.
The idea is to have UI drawing in components and anything else abstracted into its parent container.
So in your structure, if u want to change actions, u will be updating the component not the container.. which is counter intuitive.
Besides, it looks like ur container is only a wrapper for redux and then dumps it into the component. Not that useful IMHO :)
What do u think @fraserxu ? :)
The text was updated successfully, but these errors were encountered: