Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong DTS on input discontinuity #479

Open
carlosfg-flu opened this issue Dec 4, 2024 · 1 comment
Open

Wrong DTS on input discontinuity #479

carlosfg-flu opened this issue Dec 4, 2024 · 1 comment
Assignees
Labels
library Concerns the VVenC library question Further information is requested

Comments

@carlosfg-flu
Copy link

When the encoder is fed with discontinuous CTS (let's say, some incoming buffers are lost) it outputs wrong DTS.

I've prepared a PR that adds a simple test showing what's happening: #478 In this example, the ticks per seconds parameter is configured to "auto" (cfg.m_TicksPerSecond = -1) and the framerate to 30. The result is as follow:

Incoming CTS:

0 1 2 3 4 5 6 7 8 9 10 [JUMP FW] 21 22 23 24 25 26 27 28 29

Outgoing DTS:

5 -4 [JUMP BW] -3 -2 -1 0 1 2 3 14 5 [JUMP BW] 6 7 18 19 20 21 22 23 24
@adamjw24 adamjw24 added question Further information is requested library Concerns the VVenC library labels Dec 4, 2024
@adamjw24
Copy link
Member

adamjw24 commented Dec 6, 2024

So... we discussed it. As I understand, this is an issue when the client code has to skip frames for some reason. Correct me I am wrong, but this can really only heppen in live scenarios, right?

VVenC is an offline encoder and it seems an overkill to add all this logic to handle input discontinuities. We would probably need to add a scene cut or similar also, which adds a ton of logic.

We will eventually try and improve it, so at least the output timings are not incosnsitent, but as its outside of the scope of the main use case of VVenC, this is a lower priority for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
library Concerns the VVenC library question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants