-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add k-band and iid energy score estimator #25
Comments
The iid energy score estimator has been used in a few studies and would be a nice, straightforward addition to the package. I would avoid including the k-band estimator for now - there are some errors in Equation 16 of Berk & Ziel, 2019, and this approximation isn't used elsewhere. The fraction in Equation 15 should also be 2/M rather than M/2, see e.g. Moller et al., 2013, which is important to remember when we implement it. |
All right @sallen12. - We've used the |
Thanks for the link to the paper. It's probably just a notational misunderstanding then, but in your Eq 26, if K < M, then for any m > K, the lower bound on the second summation, k = m, will be higher than the upper bound, K. In this case, is it assumed that the summation is zero? |
Hi, what we did, is essentially taking: |
Thanks for clarifying. So, just to check I've understood, the second summation in Eq 26 starts from As an aside, for the implementation, it would be useful to randomise the ensemble members before applying this formula (also for the iid formula). Otherwise, if there is some sort of ordering among the ensemble members, e.g. because of how the ensembles are sampled from the predictive distribution, then only taking differences between nearby members (as is the case when |
Yeah, or it ends at Essentially shuffle the ensembles once? Not sure how this will work with the gufuncs, but generally agree that it makes sense. Will check and also put a seed in the estimator 👍 |
Great, all clear now, thanks a lot! |
If you have a lot of samples/scenarios/ensembles but little time (or little computational power):
Equations 15 and 16 in Berk & Ziel, 2019
The text was updated successfully, but these errors were encountered: