Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support tags for go list command #170

Closed
2 tasks done
augbed opened this issue Sep 1, 2024 · 3 comments
Closed
2 tasks done

feature: support tags for go list command #170

augbed opened this issue Sep 1, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@augbed
Copy link
Contributor

augbed commented Sep 1, 2024

Did you check docs and existing issues?

Is your feature request related to a problem? Please describe.

Currently it's not possible to run tests that have build tags, I can provide -tags as parameter to go_test_args, but when plugin runs go list they are missing and the command fails.

Describe the solution you'd like to see.

Pass the same tags argument from go_test_args to go list command.

Describe alternatives you've considered.

Have config argument for plugin itself where arguments to go list could be provided.

Additional context

No response

@fredrikaverpil
Copy link
Owner

Hi and thanks for the report!

Ok so this is definitively something we should fix. Before I saw #171, I figured we could add a specific go_list_args option. I think this would allow more control. What do you think?

@augbed
Copy link
Contributor Author

augbed commented Sep 3, 2024

Hey, no problem. Thank you for your work!

go_list_args sounds good. It might be confusing for a user to know that he needs to pass -tags to both but a note in readme about it is probably good enough. I will update the pull request!

@fredrikaverpil
Copy link
Owner

This was fixed by #172, closing this.

@fredrikaverpil fredrikaverpil closed this as not planned Won't fix, can't repro, duplicate, stale Sep 5, 2024
@fredrikaverpil fredrikaverpil reopened this Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants