fix: testify tabletest's subtest operand not recognized #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
fredrikaverpil
force-pushed
the
testify-operand
branch
2 times, most recently
from
e4789b2 to
0dfec3f
Compare
fredrikaverpil
commented
Jan 24, 2025
| ; query for subtest, like t.Run() | ||
| (call_expression | ||
| function: (selector_expression | ||
| operand: (identifier) @test.operand (#match? @test.operand "^(s|suite)$") |
There was a problem hiding this comment.
To maintain complete backward compatibility from what we used to have, this line should not even be in here.
Suggested change
| operand: (identifier) @test.operand (#match? @test.operand "^(s|suite)$") |
But if we remove it, tree-sitter can become confused if it encounters e.g. gin.Run or somethingelse.Run.
fredrikaverpil
force-pushed
the
testify-operand
branch
5 times, most recently
from
3130297 to
08cf763
Compare
fredrikaverpil
changed the title
fredrikaverpil
changed the title
fredrikaverpil
changed the title
fredrikaverpil
force-pushed
the
testify-operand
branch
3 times, most recently
from
742d2fe to
47d6383
Compare
|
I'm not sure why exactly, but when running "nearest test" on 
|
fredrikaverpil
force-pushed
the
testify-operand
branch
from
47d6383 to
fb2da0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #275