Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC compiler warnings #111

Open
baconpaul opened this issue Sep 8, 2023 · 4 comments
Open

MSVC compiler warnings #111

baconpaul opened this issue Sep 8, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@baconpaul
Copy link
Collaborator

in #81 we turned on -Wall -Wextra -Wpedantic -Werror for GCC and CLang

We have not done this for MSVC. We should do that for sure one day soon!

@defiantnerd
Copy link
Collaborator

Which compiler flags do we want exactly:

  • /W4 Enable warning level 4 or even /Wall?
  • /WX Treat warnings as errors

-Wextra and -Wpedantic have no equivalent in Visual Studio.

@baconpaul
Copy link
Collaborator Author

I have absolutely no idea! :)

@defiantnerd
Copy link
Collaborator

I have enabled them for a test and there are a few issues we need to solve first. Interesting enough, those issues should have been detected by GCC/Clang, too. ??

@baconpaul
Copy link
Collaborator Author

Yeah its nice to have multiple compilers so you can get the varied warnings!

@defiantnerd defiantnerd added the enhancement New feature or request label Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants