Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing timer.cpp in newer VST3 SDK releases breaks linux build #266

Closed
mtytel opened this issue Jul 5, 2024 · 6 comments
Closed

Removing timer.cpp in newer VST3 SDK releases breaks linux build #266

mtytel opened this issue Jul 5, 2024 · 6 comments

Comments

@mtytel
Copy link
Contributor

mtytel commented Jul 5, 2024

If you use a newer (3.7.9) or later vst3 sdk, then the removal of timer.cpp actually breaks the build.
It worked for me when I left timer.cpp included with the newer vst3 sdk builds.

get_filename_component(full_path_test_cpp ${VST3_SDK_ROOT}/base/source/timer.cpp ABSOLUTE)

@baconpaul
Copy link
Collaborator

Sigh. OK I wonder if there is a cmake-time way to check the version. The problem is timer.cpp throws a bunch of warnings and errors in older SDKs.

@mtytel
Copy link
Contributor Author

mtytel commented Jul 5, 2024

I think you retrieve the vst3 sdk version in cmake earlier. I can make a pull request if you want.

@baconpaul
Copy link
Collaborator

Oh you are correct, we do so about 15 lines above

so a

if (${SDK_VERSION} VERSION_LESS 3.7.9) around that line seems right to me.

If you could do a PR that'd be great, otherwise I can run it through tomorrow.

@mtytel
Copy link
Contributor Author

mtytel commented Jul 5, 2024

#269

@defiantnerd
Copy link
Collaborator

this looks good for me.

@baconpaul
Copy link
Collaborator

yup all merged. Thanks matt!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants