-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing timer.cpp in newer VST3 SDK releases breaks linux build #266
Comments
Sigh. OK I wonder if there is a cmake-time way to check the version. The problem is timer.cpp throws a bunch of warnings and errors in older SDKs. |
I think you retrieve the vst3 sdk version in cmake earlier. I can make a pull request if you want. |
Oh you are correct, we do so about 15 lines above so a if (${SDK_VERSION} VERSION_LESS 3.7.9) around that line seems right to me. If you could do a PR that'd be great, otherwise I can run it through tomorrow. |
this looks good for me. |
yup all merged. Thanks matt! |
If you use a newer (3.7.9) or later vst3 sdk, then the removal of timer.cpp actually breaks the build.
It worked for me when I left timer.cpp included with the newer vst3 sdk builds.
clap-wrapper/cmake/base_sdks.cmake
Line 137 in 497f40a
The text was updated successfully, but these errors were encountered: