Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UI): create a dark mode toggle #932

Closed
wants to merge 1 commit into from
Closed

feat(UI): create a dark mode toggle #932

wants to merge 1 commit into from

Conversation

a2937
Copy link
Member

@a2937 a2937 commented Jul 26, 2024

Checklist:

Closes #828

I updated the CSS so that it has a toggle for dark mode. The only thing I'm not quite satisfied with is that there is no indicator on the button to determine whether or not the website is already in dark mode. However it is quite apparent in the website itself.

@a2937 a2937 requested a review from a team as a code owner July 26, 2024 16:11
Copy link

This is a quick reminder that we can not accept pull requests from forks (including staff and prior contributors).

This repo is a "special" case because of how we build, test and deploy the codebase. If you are working on something, Please open a new pull request from a branch on this repository.

@github-actions github-actions bot closed this Jul 26, 2024
@raisedadead
Copy link
Member

Hey @a2937!

I noticed you worked on this. And it was closed by the bot. Let me confirm with @ahmaxed if this is something we want in the first place, if we do and he confirms you should be able to push your branch to this repo (upstream) directly and recreate the PR.

Thanks.

@ahmaxed
Copy link
Member

ahmaxed commented Aug 2, 2024

Thanks for working on this feature, @a2937.
I will update the issue with further spec and look forward to seeing this feature on news.

@a2937
Copy link
Member Author

a2937 commented Aug 2, 2024

Thank you. I appreciate being given this wonderful opportunity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

freecodecamp.org/news/ dark mode theme
3 participants