Small fixes to improve code, fix crash condition #2335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 12, 2024 09:38
strlcpy has undefined behaviour in case the copied string regions overlap. On platforms with a vector optimized memcpy implementation, overlapping regions may crash the process e.g. with Child process pid=0 terminated abnormally: Illegal instruction: 4 At this call-site the strlcpy parameters almost certainly overlap. Refactor the code to do the intended functionality in-place.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fixes to improve the codebase.
Major improvement in pkg_add behaviour on MacOS/amd64|arm64. The process crashed due to improper use of strlcpy, with this improvement, 9 kyua tests related to pkg_add pass.