Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the pin for shiboken6 #1061

Open
almet opened this issue Jan 27, 2025 · 2 comments · May be fixed by #1084
Open

Remove the pin for shiboken6 #1061

almet opened this issue Jan 27, 2025 · 2 comments · May be fixed by #1084

Comments

@almet
Copy link
Member

almet commented Jan 27, 2025

Shiboken6 issued version 6.8.1.1 in last december. This version was released only for macOS, as as such makes poetry fail to work on other OSes.

We've pinned this version for our 0.8.1 release and now back-ported the changes on the main branch:

shiboken6 = [
{version = "*", platform = "darwin"},
{version = "<6.8.1.1", platform = "linux"},
{version = "<6.8.1.1", platform = "win32"},
]

Fedora is the only distro we know that issued a release for this 6.8.1.1 version. The .spec file for Fedora packaging replaces the information in pyproject.toml by any version:

# Bypass the version pin for Fedora as the 6.8.1.1 package is causing trouble
# A 6.8.1.1 package was only released with a wheel for macOS, but was picked by
# Fedora packagers. We cannot use "*" when PyPI is involved as it will fail to download the latest version.
# For Fedora, we can pick any of the released versions.
sed -i '/shiboken6 = \[/,/\]/c\shiboken6 = "*"' pyproject.toml

Once a new version of shiboken is out we should remove these: https://pypi.org/project/shiboken6/#history

@i300220
Copy link

i300220 commented Feb 18, 2025

Fedora 41:

Problem: python3-shiboken6-6.7.2-4.fc41.i686 from fedora has inferior architecture
  - installed package dangerzone-0.8.1-1.fc41.x86_64 requires python3.13dist(shiboken6) < 6.8.1.1~~, but none of the providers can be installed
  - cannot install both python3-shiboken6-6.8.2.1-1.fc41.x86_64 from updates and python3-shiboken6-6.7.2-4.fc41.x86_64 from @System
  - cannot install both python3-shiboken6-6.8.2.1-1.fc41.x86_64 from updates and python3-shiboken6-6.7.2-4.fc41.x86_64 from fedora
  - cannot install the best update candidate for package python3-shiboken6-6.7.2-4.fc41.x86_64
  - cannot install the best update candidate for package dangerzone-0.8.1-1.fc41.x86_64

Package                                               Arch         Version                                               Repository                         Size
Skipping packages with conflicts:
 python3-shiboken6                                    x86_64       6.8.2.1-1.fc41                                        updates                       635.6 KiB

@apyrgio
Copy link
Contributor

apyrgio commented Feb 18, 2025

Ouch, this was not supposed to happen:

$ rpm -qi --requires dangerzone-0.8.1-1.fc41.x86_64.rpm | grep shiboken6
python3.13dist(shiboken6) < 6.8.1.1~~

It seems that our sed command in our dangerzone.spec file did not work somehow. We will have a release out then for Fedora 40 and 41, as we did a few weeks ago for Debian Trixie.

apyrgio added a commit that referenced this issue Feb 19, 2025
Remove the Shiboken6 pin for our Linux and macOS platforms, since a new
upstream package has been released, that has wheels for every platform.

Also, remove the `sed` command from our dangerzone.spec, whose purpose
was to nullify this pin for our Fedora packages.

Fixes #1061
@apyrgio apyrgio linked a pull request Feb 19, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

3 participants