-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is 40 seconds still a good default timeout for a sync? #1025
Is 40 seconds still a good default timeout for a sync? #1025
Comments
sources=1000, messages=2000, replies=2000, run_count=3client version 0.1.6-dev-20200407-060103 (latest as of now)Each run, after 120 seconds I saw IMPORTANT: We don't see an error after 120 seconds NOT because of the 120 second default proxy timeout, but because we try our 40-second sync 3 times before showing an error |
Here are the precise steps I took, information about my system, and results:
Test:
Results: I've also tested with 300 sources and see timeouts much more frequently. For some reason it's taking a lot longer on my staging server to populate the cache I believe, and I'm not sure this is a problem we have to worry about with production systems. In order to see more of what's going on on the server I'll need to add logging or rely on logging patches that @redshiftzero or @rmol or anyone else has? |
In my app-staging based on commit freedomofpress/securedrop@bc06d98:
Redis has the keys and the fingerprints.
|
For each source, the code has to go and look for all the submissions, in my local test/experiment that is causing time increase in a few folds. I will get back with numbers later in the week. |
Per https://github.com/freedomofpress/securedrop-workstation/wiki/Timeouts it is 60 seconds now, and we have a few other issues tracking improvements in this area, so closing this old ticket as stale. |
Description
Are these measurements still correct? If not, what are the new measurements for how long each api request takes?
Spawned from #1007 (comment)
Here's some current data to go on for how long our three calls take. We currently use the default timeout of 40 seconds for each of these calls, and this will be used once freedomofpress/securedrop-proxy#145 is fixed.
sources=300, messages=600, replies=600, run_count=3
get_sources
endpointget_all_submissions
endpointget_all_replies
endpointsources=1000...
[need test results]
The text was updated successfully, but these errors were encountered: