Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

info on missed move package #10

Open
holymoly opened this issue Jun 9, 2023 · 2 comments
Open

info on missed move package #10

holymoly opened this issue Jun 9, 2023 · 2 comments

Comments

@holymoly
Copy link

holymoly commented Jun 9, 2023

It would be nice if a error message could be raised if the server did not receive a "move" message from client. As it defaults to "move|up\n" it would be an information for the player. Because if this leads to "loose" no further message are received.

@freehuntx
Copy link
Owner

Added

@tmolitor-stud-tu
Copy link

tmolitor-stud-tu commented Dec 29, 2024

Delivered via ChaosPost from 38C3:
8qDTDXr7TDq1Uax-snT33A_36891d4ec9d20e41199b74289d8069cd6231e05b
VAtQXMhbR5Sf0B1V7X1mnA_f33325ee705816f80746f394a72e25a4d3a0adf2

Transcript:
Re: Issue #10
Unfortunately the issue is only partially fixed. An error message is sent if the first command doesn't arrive in time, but in subsequent turns the last movement direction is repeated instead, with no error message.
The issue is in Game.ts, Line 180-181 (https://github.com/freehuntx/gpn-tron/blob/master/server/Game.ts#L180) is not executed ater the first turn, because the Player action is never reset to NONE,

@freehuntx freehuntx reopened this Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants