Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce dry-run APIs for runtime calls and XCM #977

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

asiniscalchi
Copy link
Member

@asiniscalchi asiniscalchi commented Feb 6, 2025

PR Type

Enhancement, Tests


Description

  • Added dry-run APIs for runtime calls and XCM.

  • Integrated xcm-runtime-apis dependency for dry-run functionality.

  • Updated metadata to include new dry-run API definitions.

  • Adjusted Cargo.toml files to include necessary dependencies and features.


Changes walkthrough 📝

Relevant files
Enhancement
lib.rs
Implement dry-run APIs for runtime and XCM                             

runtime/laos/src/lib.rs

  • Added dry-run API implementations for runtime calls and XCM.
  • Imported necessary modules for xcm-runtime-apis.
  • Integrated DryRunApi trait into the runtime.
  • +13/-0   
    Dependencies
    Cargo.toml
    Add xcm-runtime-apis dependency                                                   

    Cargo.toml

  • Added xcm-runtime-apis dependency.
  • Ensured compatibility with the stable branch of Polkadot SDK.
  • +1/-0     
    Cargo.toml
    Include xcm-runtime-apis in runtime dependencies                 

    runtime/laos/Cargo.toml

  • Added xcm-runtime-apis to workspace dependencies.
  • Updated std feature to include xcm-runtime-apis.
  • +2/-0     
    Configuration changes
    Cargo.toml
    Update Polkadot dependencies with rococo-native feature   

    node/Cargo.toml

  • Added rococo-native feature to Polkadot CLI and service dependencies.
  • +2/-2     
    Tests
    metadata15.golden
    Update metadata with dry-run API definitions                         

    runtime/laos/src/tests/metadata15.golden

  • Updated metadata to include dry-run API definitions.
  • Added new types and methods for dry-run functionality.
  • Documented the purpose and usage of the dry-run APIs.
  • +424/-2 

    Need help?
  • Type /help how to ... in the comments thread for any questions about PR-Agent usage.
  • Check out the documentation for more information.
  • @asiniscalchi
    Copy link
    Member Author

    /describe

    Copy link

    github-actions bot commented Feb 6, 2025

    PR Description updated to latest commit (7ed7e5c)

    @github-actions github-actions bot changed the title added dry run apis Add dry-run APIs for XCM and runtime calls Feb 6, 2025
    @asiniscalchi
    Copy link
    Member Author

    /describe

    Copy link

    github-actions bot commented Feb 6, 2025

    PR Description updated to latest commit (004ec22)

    @github-actions github-actions bot changed the title Add dry-run APIs for XCM and runtime calls Introduce dry-run APIs for runtime calls and XCM Feb 6, 2025
    @asiniscalchi asiniscalchi merged commit adaf04c into main Feb 6, 2025
    11 checks passed
    @asiniscalchi asiniscalchi deleted the feature/add_dry_run_api branch February 6, 2025 15:37
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants