Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physics engine uses different units for time #488

Open
arthurkehrwald opened this issue Nov 11, 2024 · 1 comment
Open

Physics engine uses different units for time #488

arthurkehrwald opened this issue Nov 11, 2024 · 1 comment

Comments

@arthurkehrwald
Copy link
Contributor

Seconds, milliseconds, and microseconds are all used in the physics code. Often without the variable names indicating what unit is used. This is tedious to work with because every time you work with a time variable you have to figure out what unit it is in. Is there any reason not to just use seconds for everything?

@freezy
Copy link
Owner

freezy commented Nov 11, 2024

Most of the physics code was ported 1:1 from VPX, so much of the nomenclature comes from there.

So no, there is no particular reason, certainly not deliberate, and yes, a PR to improve this is welcome. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants