Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dimensions argument from earcut function? #3

Open
Talon1024 opened this issue Jul 15, 2023 · 2 comments
Open

Remove dimensions argument from earcut function? #3

Talon1024 opened this issue Jul 15, 2023 · 2 comments
Labels
good first issue Good for newcomers

Comments

@Talon1024
Copy link

dimensions is the number of coordinates per vertex in the input array. Dimensions must be 2.

If it has to be 2, that effectively defeats the purpose of having that argument there in the first place.
@frewsxcv
Copy link
Owner

Sounds good to me

@frewsxcv frewsxcv added the good first issue Good for newcomers label Jul 16, 2023
@kylebarron
Copy link

FWIW in the upstream JS implementation, dimensions defaults to 2, but it accepts higher dimensional coordinates. It only does the triangulation on the first two dimensions though https://github.com/mapbox/earcut#usage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@frewsxcv @Talon1024 @kylebarron