Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gelbooru image viewer doesn't work anymore #19

Open
Tamaniha opened this issue May 26, 2020 · 14 comments · May be fixed by #20
Open

Gelbooru image viewer doesn't work anymore #19

Tamaniha opened this issue May 26, 2020 · 14 comments · May be fixed by #20

Comments

@Tamaniha
Copy link

The script stopped working on Gelbooru for about a week now. It still works on rule34 so something must've changed on Gelbooru.

@Tamaniha
Copy link
Author

It's definitely broken on gelbooru because it still works on other sites. Not sure what changed.
image

@Tamaniha
Copy link
Author

Tamaniha commented Jun 6, 2020

Please fix this great script!

@DimensioX1
Copy link

Same problem here, works fine on every other site but stopped working on gelbooru the other day

@Tamaniha
Copy link
Author

Tamaniha commented Jul 11, 2020

I really hope this gets fixed. I think fixing it is easy for a pro.
I tried to fix it but failed due to my limited knowledge in javascript.

wexavier added a commit to wexavier/GelbooruEnhancement that referenced this issue Aug 5, 2020
Signed-off-by: wexavier <[email protected]>
@wexavier wexavier linked a pull request Aug 5, 2020 that will close this issue
@Tamaniha
Copy link
Author

Thanks!
What @wexavier did fixed the gallery view but it's not loading the images properly for some reason and this keeps popping up whenever an image is clicked.
Untitled

@wexavier
Copy link

@Tamaniha
Strange, it's working fine for me...
When you click on any image for the first time you should get a window asking for permission to cross-origin resources like this:
Annotation 2020-08-21 144838
Make sure you click on "always allow domain".
I did't add a @connect tag for this domain because it seems to interfere with the progress bar functionality (it just stops working but the image will still be loaded properly).
If you ended up blacklisting it, you can revert that in the settings under the XHR Security section.
And if the domain is whitelisted and you're still getting this error please post the error message(s) you are getting in the console.

@Tamaniha
Copy link
Author

I did that and tried reinstalling the script but the permission window didn't pop up again for some reason so I tried clearing the cookies and that fixed it and I got the window asking for permission.
Many thanks!

@friendlyanon please approve this pull request!

@Tamaniha
Copy link
Author

Tamaniha commented Jan 4, 2021

It stopped working again but I'm not getting any errors in the console this time

@DimensioX1
Copy link

same

@Tamaniha
Copy link
Author

Tamaniha commented Feb 6, 2021

we need your help @wexavier

wexavier added a commit to wexavier/GelbooruEnhancement that referenced this issue Feb 8, 2021
@Tamaniha
Copy link
Author

@wexavier Thank you very much
There's an issue because it works sometimes and doesn't work for most of the time when I click on an image on the same page. I have no clue how to reproduce the actions that make it work but usually when the page opens and I click on an image the first time it doesn't work but then I click go back and press page up/page down and try again on another image until it works. And when It starts to work on the page it also works on the image I clicked on the first time.
No Idea what is causing this and I've tried it on chrome and firefox and got the same result

@wexavier
Copy link

This did happen a few times for me as well, but it's not that common. Without a console error or a way to reproduce the bug it's hard to pinpoint the part of the code causing it.

@Tamaniha
Copy link
Author

Tamaniha commented Mar 8, 2021

My way to get around it now is to keep hard reloading the page until it works which it does most of the time

@Tamaniha
Copy link
Author

@wexavier It's not working correctly again and sometimes works but only for the last 10 images or so. Are you having this issue too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants