-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
brd2svg fails when element name has illegal characters #6
Comments
Thanks, good point! |
I took a look to see what font issues you are talking about and I see other people are having troubles getting brd2svg run without errors. Here is my flow: Still, saying I "got brd2svg to work" is a bit exaggerated :-) I filed this bug while trying first to get the script to run without errors. I really needed this to be able to represent the LiPo Rider board in a wiring diagram , so I expected to get an SVG with a green or red board showing all the components in a top view. Frankly, I think this tool needs to be rewritten from grounds-up in your favorite scripting language (Python or whatever) and base its input on the native XML from Eagle 6.x+ Note: Reedited comment with minor fixes |
Thanks! So basically no changes were required for it to run? See issue #5 on how to properly "import" the generated files. The breadboard image should indeed look much better. Since not all Eagle files are created equal, you might have to tweak some parameters in the params.xml. Especially for mapping layers, if I remember correctly. The tool could definitely use a rewrite of the Eagle part, so that it's no longer necessary to run Eagle itself. (I'll make an issue for that.) On the other hand, given that it's written in Qt makes makes it possible to integrate it into the UI at some point. |
It seems that there is no sanitation done on characters that appear in element names.
I tried converting a board (http://www.seeedstudio.com/wiki/images/0/0b/Lipo_rider_v1.1.zip) that unfortunately has an element (on/off switch) called "ON<-->OFF".
The '<' and '>' are then copied into the XML unescaped (should be converted to "<" and ">" respectively). I haven't checked for other characters that might need escaping but I would guess they are not handled correctly as well.
Note: modified comment to escape the original XML escape sequence for '<'. It seems markdown has munched my original sequence and converted it to a real '<', making my comment not really clear.
The text was updated successfully, but these errors were encountered: