Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributor access #82

Open
jugutier opened this issue Oct 16, 2018 · 7 comments
Open

Contributor access #82

jugutier opened this issue Oct 16, 2018 · 7 comments

Comments

@jugutier
Copy link

Hi @frostney just seeing that this repo got quite some attention after I added it on the official react native documentation maybe it would help for me to put some time on managing PRs & keeping it up to date?

Couldn't find your email anywhere but you should see mine in my Github profile. Please let me know if having me as a contributor on this repo & NPM is something that you'd be open to :)

@thorbenprimke
Copy link
Collaborator

@jugutier - I would be happy to add you but I don't have the rights. @maicki and I can review and merge pull requests though.

We have been waiting for @frostney to publish a new version to NPM - #78 - or get access to do it ourselves.

@brody4hire
Copy link

I just published create-react-native-module, based on this project, with very basic view component support added as an option. Contributions would be welcome.

@woyhat
Copy link

woyhat commented Apr 7, 2019

@jugutier - I really don't think that the official react native documentation about making native module should point to this repository as 1) the author is unobtainable, 2) he didn't grant access to people willing to maintain the project.
It will be really frustrating for devs going through official documentation that should be trustworthy to stuck in the middle of the process and find out after some digging that the cli tool is basically dead and buggy. It makes React Native look unprofessional.
Also less experienced devs or iOS/Android devs new to JS ecosystem would end up wasting a whole lot of time before they grasp what's going on.

@jugutier
Copy link
Author

jugutier commented Apr 7, 2019

@woyhat - I agree we should have a repo up to date and there’s many changes we would like to see in this initial structure.

@frostney - would you be able to grant some of us admin access here?

We can look into our own fork if need be.

@brody4hire
Copy link

I have been publishing brodybits/create-react-native-module with some up-to-date changes including recent PRs such as #102, #104, and #105.

I hope we can converge together on an updated project somehow.

In case we do not hear back from @frostney, I can think of the following alternatives:

In any case I think we should express our appreciation to @frostney for contributing this nice package for the rest of us.

@iamchathu
Copy link

@brodybits Any plans on updating existing module to new Gradle and android projects without pain

@brody4hire
Copy link

Any plans on updating existing module to new Gradle and android projects without pain

Answered in brody4hire/create-react-native-module#19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants