Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Version Disables Corner Dash #107

Closed
kiinii-pixel opened this issue Feb 5, 2025 · 5 comments
Closed

New Version Disables Corner Dash #107

kiinii-pixel opened this issue Feb 5, 2025 · 5 comments

Comments

@kiinii-pixel
Copy link

After updating my extensions I can no longer dash in the top left corner.
When I disable this extension it works again and when I enable it it breaks.
Before I could do both at the same time.

@fthx
Copy link
Owner

fthx commented Feb 5, 2025

That's probably because of:

Main.layoutManager._destroyHotCorners();

@fthx
Copy link
Owner

fthx commented Feb 5, 2025

Ok, could you replace this by:
Main.layoutManager._updateHotCorners();
and see if this is ok?

It basically works but let's check first.

@fthx
Copy link
Owner

fthx commented Feb 5, 2025

Ok, I suspected this could cause a recursion in hot-corners-updated signal call and that's the case.
So:

  • you can simply remove, as before, this line
  • if some users complain about this, I'll rewrite the GS hot corners code to avoid signal emitting (but that's some work)

@Lurux
Copy link

Lurux commented Feb 11, 2025

That's probably because of:

dock-from-dash/extension.js

Line 264 in ead1ee9

Main.layoutManager._destroyHotCorners();

I'm not entirely sure, what's the purpose of this line ? I mean, it's pretty clear what it does, but why did you need to add it in the first place ?

@fthx
Copy link
Owner

fthx commented Feb 12, 2025

Ok, this cleanup was initiated with a bug in another extension I did, that needed to update hot corners every time I exit overview. (Causing hot corners list to grow up through session time.)
That's not the case of DfD, so I removed it.

3f6f3d6

@fthx fthx closed this as completed Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants