From fb71e3cc9d5b794669a13e892f3432208ed8b7f6 Mon Sep 17 00:00:00 2001
From: "Matteo a.k.a. Fugerit" <m@fugerit.org>
Date: Wed, 3 Feb 2021 10:32:15 +0100
Subject: [PATCH] 0.3.3.6 (2021-02-03) -------------------- + fremarker html
 support now print style attribute only if has values

---
 docgen/parameters.json                           |  4 ++--
 docgen/release-notes.txt                         |  6 +++++-
 fj-doc-base/pom.xml                              |  2 +-
 fj-doc-ent/pom.xml                               |  2 +-
 fj-doc-freemarker/pom.xml                        |  2 +-
 .../fm_doc/template/macro/html_element.ftl       | 16 ++++++++++------
 fj-doc-mod-fop/pom.xml                           |  2 +-
 fj-doc-mod-itext/pom.xml                         |  2 +-
 fj-doc-mod-jxl/pom.xml                           |  2 +-
 fj-doc-mod-pdfbox/pom.xml                        |  2 +-
 fj-doc-mod-poi/pom.xml                           |  2 +-
 fj-doc-sample/pom.xml                            |  2 +-
 pom.xml                                          |  2 +-
 13 files changed, 27 insertions(+), 19 deletions(-)

diff --git a/docgen/parameters.json b/docgen/parameters.json
index ae82412e1..4cd56f29d 100644
--- a/docgen/parameters.json
+++ b/docgen/parameters.json
@@ -1,8 +1,8 @@
 {
 	"title" : "Venus (Fugerit Document Generation Framework)",
 	"name": "Venus",
-	"version" : "0.3.3.5",
-	"date" : "02/02/2021",
+	"version" : "0.3.3.6",
+	"date" : "03/02/2021",
 	"organization" : {
 		"name" : "Fugerit Org",
 		"url" : "https://www.fugerit.org"
diff --git a/docgen/release-notes.txt b/docgen/release-notes.txt
index 25a482ad5..ed0da7ac0 100644
--- a/docgen/release-notes.txt
+++ b/docgen/release-notes.txt
@@ -1,4 +1,8 @@
-0.3.3.5 (2021-02-02)
+0.3.3.6 (2021-02-03)
+--------------------
++ fremarker html support now print style attribute only if has values
+
+0.3.3.5 (2021-02-02)
 --------------------
 + Added support for italic and bold italic style in freemarker html
 
diff --git a/fj-doc-base/pom.xml b/fj-doc-base/pom.xml
index 44f2dae44..c49b1ab0f 100644
--- a/fj-doc-base/pom.xml
+++ b/fj-doc-base/pom.xml
@@ -7,7 +7,7 @@
 	<parent>
 		<groupId>org.fugerit.java</groupId>
 		<artifactId>fj-doc</artifactId>
-		<version>0.3.3.5</version>
+		<version>0.3.3.6</version>
 	</parent>
 
 	<name>fj-doc-base</name>
diff --git a/fj-doc-ent/pom.xml b/fj-doc-ent/pom.xml
index f149ff4f4..f9583bc18 100644
--- a/fj-doc-ent/pom.xml
+++ b/fj-doc-ent/pom.xml
@@ -7,7 +7,7 @@
 	<parent>
 		<groupId>org.fugerit.java</groupId>
 		<artifactId>fj-doc</artifactId>
-		<version>0.3.3.5</version>
+		<version>0.3.3.6</version>
 	</parent>
 
 	<name>fj-doc-ent</name>
diff --git a/fj-doc-freemarker/pom.xml b/fj-doc-freemarker/pom.xml
index 536bb8863..f024d71bd 100644
--- a/fj-doc-freemarker/pom.xml
+++ b/fj-doc-freemarker/pom.xml
@@ -7,7 +7,7 @@
 	<parent>
 		<groupId>org.fugerit.java</groupId>
 		<artifactId>fj-doc</artifactId>
-		<version>0.3.3.5</version>
+		<version>0.3.3.6</version>
 	</parent>
 
 	<name>fj-doc-freemarker</name>
diff --git a/fj-doc-freemarker/src/main/resources/fm_doc/template/macro/html_element.ftl b/fj-doc-freemarker/src/main/resources/fm_doc/template/macro/html_element.ftl
index 2ab5f6b38..9bc13c1fc 100644
--- a/fj-doc-freemarker/src/main/resources/fm_doc/template/macro/html_element.ftl
+++ b/fj-doc-freemarker/src/main/resources/fm_doc/template/macro/html_element.ftl
@@ -5,11 +5,11 @@
 	<#assign elementType="${current.class.simpleName}"/>
 	<#if elementType = 'DocPhrase'>
 		<#if (current.link)??>
-		<a style="<@handleStyle styleValue=current.style/>" href="${current.link}">${current.text}</a>
+		<a <@handleStyleOnly styleValue=current.style/> href="${current.link}">${current.text}</a>
 		<#elseif (current.anchor)??>
-		<a style="<@handleStyle styleValue=current.style/>" name="${current.anchor}">${current.text}</a>
+		<a <@handleStyleOnly styleValue=current.style/> name="${current.anchor}">${current.text}</a>
 		<#else>
-		<span style="<@handleStyle styleValue=current.style/>">${current.text}</span>
+		<span <@handleStyleOnly styleValue=current.style/>>${current.text}</span>
 		</#if>
 	<#elseif elementType = 'DocNbsp'>
 		&nbsp;
@@ -17,9 +17,9 @@
 		<br/>		
 	<#elseif elementType = 'DocPara'>
 		<#if current.headLevel == 0>
-			<p style="<@handleAlign alignValue=current.align/> <@handleStyle styleValue=current.style/>">${current.text}</p>
+			<p <@handleStyleComplete styleValue=current.style alignValue=current.align/>>${current.text}</p>
 		<#else>
-			<h${current.headLevel} style="<@handleAlign alignValue=current.align/> <@handleStyle styleValue=current.style/>">${current.text}</h${current.headLevel}>
+			<h${current.headLevel} <@handleStyleComplete styleValue=current.style alignValue=current.align/>>${current.text}</h${current.headLevel}>
 		</#if>
 	<#elseif elementType = 'DocTable'>
 		<@handleTable docTable=current/>			
@@ -63,5 +63,9 @@
 
 <#macro handleAlign alignValue><#if alignValue = 1>text-align: left;<#elseif alignValue = 2>text-align: center;<#elseif alignValue = 3>text-align: right;</#if></#macro>
 
-<#macro handleStyle styleValue><#if styleValue = 2>font-weight: bold;<#elseif styleValue = 3>font-weight: underline;<#elseif styleValue = 4>font-style: italic;<#elseif styleValue = 5>font-weight: bold; font-style: italic;</#if> </#macro>
+<#macro handleStyle styleValue><#if styleValue = 2>font-weight: bold;<#elseif styleValue = 3>font-weight: underline;<#elseif styleValue = 4>font-style: italic;<#elseif styleValue = 5>font-weight: bold; font-style: italic;</#if></#macro>
+
+<#macro handleStyleOnly styleValue><#assign cStyle><@handleStyle styleValue=styleValue/></#assign><#if cStyle != '' >style="${cStyle}"</#if></#macro>
+
+<#macro handleStyleComplete styleValue alignValue><#assign cStyle><@handleStyle styleValue=styleValue/></#assign><#assign cAlign><@handleAlign alignValue=alignValue/></#assign><#if cStyle != '' || cAlign != '' >style="${cStyle} ${cAlign}"</#if></#macro>
 
diff --git a/fj-doc-mod-fop/pom.xml b/fj-doc-mod-fop/pom.xml
index cc02a0b97..a28488939 100644
--- a/fj-doc-mod-fop/pom.xml
+++ b/fj-doc-mod-fop/pom.xml
@@ -7,7 +7,7 @@
 	<parent>
 		<groupId>org.fugerit.java</groupId>
 		<artifactId>fj-doc</artifactId>
-		<version>0.3.3.5</version>
+		<version>0.3.3.6</version>
 	</parent>
 
 	<name>fj-doc-mod-fop</name>
diff --git a/fj-doc-mod-itext/pom.xml b/fj-doc-mod-itext/pom.xml
index d0607e9a8..3175181a7 100644
--- a/fj-doc-mod-itext/pom.xml
+++ b/fj-doc-mod-itext/pom.xml
@@ -7,7 +7,7 @@
 	<parent>
 		<groupId>org.fugerit.java</groupId>
 		<artifactId>fj-doc</artifactId>
-		<version>0.3.3.5</version>
+		<version>0.3.3.6</version>
 	</parent>
 
 	<name>fj-doc-mod-itext</name>
diff --git a/fj-doc-mod-jxl/pom.xml b/fj-doc-mod-jxl/pom.xml
index 865bf5555..d0e448421 100644
--- a/fj-doc-mod-jxl/pom.xml
+++ b/fj-doc-mod-jxl/pom.xml
@@ -7,7 +7,7 @@
 	<parent>
 		<groupId>org.fugerit.java</groupId>
 		<artifactId>fj-doc</artifactId>
-		<version>0.3.3.5</version>
+		<version>0.3.3.6</version>
 	</parent>
 
 	<name>fj-doc-mod-jxl</name>
diff --git a/fj-doc-mod-pdfbox/pom.xml b/fj-doc-mod-pdfbox/pom.xml
index c3c2daa06..56518cd74 100644
--- a/fj-doc-mod-pdfbox/pom.xml
+++ b/fj-doc-mod-pdfbox/pom.xml
@@ -7,7 +7,7 @@
 	<parent>
 		<groupId>org.fugerit.java</groupId>
 		<artifactId>fj-doc</artifactId>
-		<version>0.3.3.5</version>
+		<version>0.3.3.6</version>
 	</parent>
 
 	<name>fj-doc-mod-pdfbox</name>
diff --git a/fj-doc-mod-poi/pom.xml b/fj-doc-mod-poi/pom.xml
index 6b47e702e..a71d8e4a6 100644
--- a/fj-doc-mod-poi/pom.xml
+++ b/fj-doc-mod-poi/pom.xml
@@ -7,7 +7,7 @@
 	<parent>
 		<groupId>org.fugerit.java</groupId>
 		<artifactId>fj-doc</artifactId>
-		<version>0.3.3.5</version>
+		<version>0.3.3.6</version>
 	</parent>
 
 	<name>fj-doc-mod-poi</name>
diff --git a/fj-doc-sample/pom.xml b/fj-doc-sample/pom.xml
index 85dd71c65..a72fbc29e 100644
--- a/fj-doc-sample/pom.xml
+++ b/fj-doc-sample/pom.xml
@@ -7,7 +7,7 @@
 	<parent>
 		<groupId>org.fugerit.java</groupId>
 		<artifactId>fj-doc</artifactId>
-		<version>0.3.3.5</version>
+		<version>0.3.3.6</version>
 	</parent>
 
 	<name>fj-doc-sample</name>
diff --git a/pom.xml b/pom.xml
index 6ddedcb22..620bd74f7 100644
--- a/pom.xml
+++ b/pom.xml
@@ -5,7 +5,7 @@
 	<groupId>org.fugerit.java</groupId>
 	<artifactId>fj-doc</artifactId>
 
-	<version>0.3.3.5</version>
+	<version>0.3.3.6</version>
 	<packaging>pom</packaging>
 
 	<name>fj-doc</name>