Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NavigationSheet independent of NavigatorObserver #172

Open
fujidaiti opened this issue Jun 17, 2024 · 0 comments
Open

Make NavigationSheet independent of NavigatorObserver #172

fujidaiti opened this issue Jun 17, 2024 · 0 comments
Assignees
Labels
improvement Need more improvements P2
Milestone

Comments

@fujidaiti
Copy link
Owner

fujidaiti commented Jun 17, 2024

The current implementation of NavigationSheet relies on NavigatorObserver to detect page transitions within the nested navigator. However, this approach has several issues that are difficult to resolve, especially when using go_router (#170, #152). Making NavigationSheet independent of NavigatorObserver will not only solve these problems but also simplify its usage, as future APIs will eliminate the need for developers to manage a NavigatorObserver object.

@fujidaiti fujidaiti added this to the v1 milestone Jun 17, 2024
@fujidaiti fujidaiti added the P2 label Jun 17, 2024
@fujidaiti fujidaiti self-assigned this Jun 17, 2024
@fujidaiti fujidaiti added the improvement Need more improvements label Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Need more improvements P2
Projects
None yet
Development

No branches or pull requests

1 participant