From bdfd51953c7ec9f437dedac6a737aa5929e764de Mon Sep 17 00:00:00 2001 From: Lewis Denny Date: Thu, 1 Aug 2024 12:05:15 +1000 Subject: [PATCH] nit: Update project guidelines to define approval policy This patch documents the projects policy on PR approval, mainly that PRs should have two different reviewers (excluding the PR owner) approval rather than one reviewer adding both votes. --- docs/source/development/01_guidelines.md | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/docs/source/development/01_guidelines.md b/docs/source/development/01_guidelines.md index ad8b04bb1a..4cf4f06552 100644 --- a/docs/source/development/01_guidelines.md +++ b/docs/source/development/01_guidelines.md @@ -95,3 +95,11 @@ If at any time your patch no longer meets this criteria the label will be remove If you would like to bring attention to your patch before a reviewer has made it to your patch reach out in our [slack channel](https://redhat.enterprise.slack.com/archives/C03MD4LG22Z) + +## PR Approval Policy + +All pull requests must be approved by at least two reviewers, excluding the PR owner. + +Please note that this requirement is a project-specific guideline rather than a tooling constraint, as Prow does not currently support enforcing a minimum number of approvals. + +This policy is in place to ensure code quality and to minimize the risk of introducing breaking changes.