Skip to content
This repository has been archived by the owner on Aug 15, 2023. It is now read-only.

Tallies names should not be overwritten by ODW #115

Open
RemDelaporteMathurin opened this issue Jun 21, 2022 · 1 comment
Open

Tallies names should not be overwritten by ODW #115

RemDelaporteMathurin opened this issue Jun 21, 2022 · 1 comment

Comments

@RemDelaporteMathurin
Copy link
Member

Currently, if users set a tally name on instanciation, it gets overwritten:

my_tally = odw.CellTally(
    "(n,Xa)", target="copper", materials=materials, name="my_custom_name"
)

I think it can be set afterwards, but that's confusing.

@shimwell
Copy link
Member

Yep agreed we shouldn't overwrite names, perhaps it could check if there is a name and if not then set it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants