Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save video thumbnails in webP format? #30

Open
ianpegg opened this issue Feb 3, 2022 · 4 comments
Open

Save video thumbnails in webP format? #30

ianpegg opened this issue Feb 3, 2022 · 4 comments

Comments

@ianpegg
Copy link

ianpegg commented Feb 3, 2022

Hello,

Now that WP supports webP images, would it be possible to save video thumbnails in this format? Or is there already a way to configure the plugin to do this?

Browser support for webP now looks good but the plugin could still generate jpegs too for full compatibility.

@futtta
Copy link
Owner

futtta commented Feb 3, 2022

it's on my backlog, but I lack the time now. if ever you're interested & have time; the is logic to be added in lyteCache.php, which should if available (based on YT API response) should (also) download the webp version of the thumbnail and then based on accept-headers serve either webp or jpeg version.

@ianpegg
Copy link
Author

ianpegg commented Mar 7, 2022

Thank you, Frank. I completely understand you're busy. I'm in a similar situation right now but I would love to help so will circle back to this and see what I can do when I have some spare time!

@theflyingjay
Copy link

theflyingjay commented Feb 14, 2024

@ianpegg I got you fam. Changes to two files enable webp. Enjoy! I could only upload as txt. But they're php files.
tested and working. Hopefully futta can diff these changes and add them to the repo. Best plugin ever!

lyteCache.txt

wp-youtube-lyte.txt

@ianpegg
Copy link
Author

ianpegg commented Feb 15, 2024

Smashing! Thanks, @theflyingjay, this has been in my backlog for too long! I'll take a look at your code when I get five...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants