We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hi
This is a suggestion, Too many conditions check in constructor, my suggestion below
let server = new StaticServer({port: 8080, localOnly : true, keepAlive : true });
class StaticServer { constructor(opts) { if(opts) { this.port = `${opts.port}` || PORT; this.root = opts.root || ROOT; this.localOnly = opts.localOnly || false; this.keepAlive = opts.keepAlive || false; } else{ this.port = PORT; this.root = ROOT; this.localOnly = false; this.keepAlive = false; } } .... }
let me know your feedback
The text was updated successfully, but these errors were encountered:
Agreed this could be simpler, but don't think it is worth breaking changes.
Sorry, something went wrong.
[futurepress#32] Android: Fixes support of RN's Old Architecture (bro…
39546cc
…ken since v0.7.8)
No branches or pull requests
Hi
This is a suggestion,
Too many conditions check in constructor, my suggestion below
let server = new StaticServer({port: 8080, localOnly : true, keepAlive : true });
let me know your feedback
The text was updated successfully, but these errors were encountered: