Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Android linking instructions #36

Closed
ToJen opened this issue Feb 28, 2018 · 2 comments
Closed

Wrong Android linking instructions #36

ToJen opened this issue Feb 28, 2018 · 2 comments

Comments

@ToJen
Copy link

ToJen commented Feb 28, 2018

The instruction from here say:

Open up android/app/src/main/java/[...]/MainActivity.java
Add import com.futurepress.staticserver.FPStaticServerPackage; to the imports at the top of the file
Add new FPStaticServerPackage() to the list returned by the getPackages() method

However, imports are usually done in android/app/src/main/java/[...]/MainApplication.java from what I've seen with other RN projects that need linking. Also, the getPackages method only exists in MainApplication.java.

@ToJen
Copy link
Author

ToJen commented Mar 2, 2018

@fchasen

@fchasen
Copy link
Contributor

fchasen commented Mar 20, 2018

Thanks - removed, using react-native link is the preferred way to add the package.

@fchasen fchasen closed this as completed Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants