Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null_literal node. #141

Closed
wants to merge 2 commits into from
Closed

Conversation

wolfmanstout
Copy link
Contributor

Fixes #140

@github-actions github-actions bot added the grammar Related to the grammar label Aug 4, 2024
@afroozeh
Copy link
Contributor

afroozeh commented Aug 5, 2024

Is this a copy of my PR? #139

@wolfmanstout
Copy link
Contributor Author

Is this a copy of my PR? #139

Wow, no, that's an extraordinary coincidence. I did a search for outstanding issues but not PRs so I didn't see this. I'm happy to close this one although I'd suggest you link yours to the bug I filed and you can simplify the grammar change slightly: there's no need to wrap a single node "null" in a seq call.

@wolfmanstout
Copy link
Contributor Author

Is this a copy of my PR? #139

Also I had to fix highlights.scm, make sure your tests fully pass. I think it was just a subtle message at the bottom of the test log.

@afroozeh
Copy link
Contributor

afroozeh commented Aug 5, 2024

@wolfmanstout thanks for the clarification. I'll update my PR with the changes you mentioned. btw, it doesn't matter which one gets merged, I was just surprised that it was opened. My goal is for these changes to get in asap :-)

@wolfmanstout
Copy link
Contributor Author

Duplicate of #139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grammar Related to the grammar
Projects
None yet
Development

Successfully merging this pull request may close these issues.

null should correspond to a node
2 participants