You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The backends KafkaAvroBackend and MockBackend are inconsistent in how they are set up.
In KafkaAvroBackend:
self.producer is an instance of AvroProducer
self.consumer is a partial that can instantiate an AvroConsumer
In MockBackend:
self.producer is an instance of a (Mock) Producer
self.consumer is an instance of a (Mock) Consumer
It would be good to keep consistency by:
Making sure that self.consumer is the same "type" for both backends
Making sure that self.consumer and self.producer are both instances or functions. This is not necessary but I think it makes sense and makes it easier for developers since you don't have to keep track of which was implemented in which way.
I suggest that we change self.consumer to always be an instance
The text was updated successfully, but these errors were encountered:
The backends
KafkaAvroBackend
andMockBackend
are inconsistent in how they are set up.In
KafkaAvroBackend
:self.producer
is an instance ofAvroProducer
self.consumer
is apartial
that can instantiate anAvroConsumer
In
MockBackend
:self.producer
is an instance of a (Mock)Producer
self.consumer
is an instance of a (Mock)Consumer
It would be good to keep consistency by:
self.consumer
is the same "type" for both backendsself.consumer
andself.producer
are both instances or functions. This is not necessary but I think it makes sense and makes it easier for developers since you don't have to keep track of which was implemented in which way.I suggest that we change
self.consumer
to always be an instanceThe text was updated successfully, but these errors were encountered: