Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary check #1

Open
JensRantil opened this issue Jan 2, 2018 · 1 comment
Open

Unnecessary check #1

JensRantil opened this issue Jan 2, 2018 · 1 comment

Comments

@JensRantil
Copy link

https://github.com/fzakaria/space-saving/blob/master/src/main/java/com/github/fzakaria/topk/spacesaving/StreamSummary.java#L101 can be removed. Remove will remove if it's there, otherwise do nothing.
@fzakaria
Copy link
Owner

fzakaria commented Jan 2, 2018

that's true.
I think I wrote it following some whitepaper (url at the top) -- so i probably made it explicit.
If you'd like to submit a PR I'd be happy to accept.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fzakaria @JensRantil