Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error mousing over days #18

Open
admc opened this issue Apr 4, 2021 · 8 comments
Open

Error mousing over days #18

admc opened this issue Apr 4, 2021 · 8 comments

Comments

@admc
Copy link

admc commented Apr 4, 2021

Cool library, I want to use it, but I'm getting some errors:

image

Was also curious of there was any chance to pass through some props to set the height and width?

Thanks!

@g1eb
Copy link
Owner

g1eb commented Apr 4, 2021

Hi Adam, could you check the version of d3 and moment you are using? I think I've seen this error before and it was related to a version mismatch. The ones used in the demo are:

"d3": "4.11.0",
"moment": "2.19.1",

If that does not fix it please share a link to your project, I'll be happy to look into the issue.

@admc
Copy link
Author

admc commented Apr 4, 2021

Greetings,

I'm using both latest:
"d3": "^6.6.2", "moment": "^2.29.1",

I tried downgrading moment versions, which didn't seem to make any difference. I can't downgrade d3 as I'm dependent on what looks like a reorganization of the exports. It would be amazing if you could dig in!

I'm only passing in a sessions array, which does render the calendar properly.

Is there a way to pass in a height and width? I'd be happy to sponsor some development here to get this sorted out as this looks like exactly what I want in my app.

Thanks again!
Adam

@g1eb
Copy link
Owner

g1eb commented Apr 4, 2021

Unfortunately D3 made some changes in later versions that are not backwards compatible. I can take a look at updating the library to support the latest version of d3 - no idea how big that update would be, it will have to be a major version bump.

If you want me to add width and height as props for the current version - we can do that in a separate issue, thanks!

@admc
Copy link
Author

admc commented Apr 4, 2021

It would be fantastic if you were able to upgrade it to work with the latest package versions, and then add the height/width props :)

@shmkane
Copy link

shmkane commented Aug 27, 2021

Hey @g1eb, love this heat map. Any plans to upgrade to latest versions?

@shmkane
Copy link

shmkane commented Aug 27, 2021

Just FYI, I get an error mousing over the days whether I use latest d3/moment or the ones you recommended.

"d3": "4.11.0",
"moment": "2.19.1",

image
Any suggestions?

@SC4RECOIN
Copy link

same errors for me.. what version of d3 should we be using?

@shmkane
Copy link

shmkane commented Sep 1, 2021

same errors for me.. what version of d3 should we be using?

I was able to resolve this issue by using

"moment": "2.19.1",
"d3": "5.16.0",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants