Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong search filters for widget type "Value Relation" (key-value fields) #575

Open
1 task done
gisuser0 opened this issue Aug 2, 2023 · 9 comments · Fixed by #577
Open
1 task done

Wrong search filters for widget type "Value Relation" (key-value fields) #575

gisuser0 opened this issue Aug 2, 2023 · 9 comments · Fixed by #577
Assignees
Labels
bug Something isn't working
Milestone

Comments

@gisuser0
Copy link

gisuser0 commented Aug 2, 2023

Checklist

  • I've searched through the existing issues and this bug has never been reported before

Subject of the issue

The fields set in QGIS with the Widget Type "Value Relation" (pairs key-value) are correctly displayed using the single query button (the value is shown) while are not correctly displayed using the other bbox and polygon query buttons (the key is shown).
This issue also affects the search tools (column search in the attribute table and search widget) since they search the key and not the values.

Steps to reproduce

  • open the online demo (https://v36.g3wsuite.it/it/map/demo-36/)

  • query the "buildings" layer with the different tools and check the different results of the attribute called "Subtype - Dependent on the value of Type"

image

  • open the attribute table and search "A1" in the "Subtype - Dependent on the value of Type" column. Although there are values = "A1", the search returns no values

image

Environment

  • g3w-admin: 3.6.6
  • g3w-client: 3.8.6
  • browser: Chrome, Firefox, Safari
  • operating system: Windows, Linux, Mac OS

Link to your project

No response

Additional info

No response

@gisuser0 gisuser0 added the bug Something isn't working label Aug 2, 2023
@Raruto
Copy link
Contributor

Raruto commented Aug 7, 2023

Hi @gisuser0,

thanks for the report.


Here are some notes to speed up the review process:

  1. query the "buildings" layer with the different tools and check the different results of the attribute called "Subtype - Dependent on the value of Type"
  2. open the attribute table and search "A1" in the "Subtype - Dependent on the value of Type" column

Please also attach some self-explanatory images proving each of your statements (closer to each line is also better..)


  • browser: Chrome, Firefox, Safari
  • operating system: Windows, Linux, Mac OS

In this section, you should report only the information related to the environment you have already tested.

If you have really tested them all, please report each combination of tested software versions in detail (since for each operating system there are several versions available it is difficult find out which environment has already been tested..).


👋 Raruto

@wlorenzetti
Copy link
Member

@gisuser0 thanks for the report, I think they will be fixed on next 3.7 version.

@wlorenzetti wlorenzetti added this to the v3.7 milestone Aug 7, 2023
@gisuser0
Copy link
Author

gisuser0 commented Aug 7, 2023

@wlorenzetti and @Raruto, thanks for the reply.
The browsers and the OS indicated above are used to reproduce the issue directly using the online-demo.
Do I need to "attach some self-explanatory images proving each of my statements" or the issue is clear?

@Raruto
Copy link
Contributor

Raruto commented Aug 7, 2023

I think they will be fixed on next 3.7 version.

@gisuser0 while you wait for a fix:

The browsers and the OS indicated above are used to reproduce the issue directly using the online-demo.

I've pointed out because some browsers are not available for all platforms and even the latest available versions may vary from one operating system to another.

Nothing dramatic but for the future please remember, when reporting your tests, to always write down the exact versions of each software used in order to speed up the work for those who can help you later (and also to make sure that you will be able to replicate them once solved).

Do I need to "attach some self-explanatory images proving each of my statements" or the issue is clear?

If it's feasible, also attach some images (or gif) within your first #575 (comment) in order to make it clearer.

That way, anyone who might run into this issue in the future should easily get an idea (although that link may be dead).

Thanks in advance for your cooperation,
Raruto

@Raruto Raruto changed the title Issue with key-value fields Wrong search filters for widget type "Value Relation" (key-value fields) Aug 8, 2023
@gisuser0
Copy link
Author

gisuser0 commented Aug 18, 2023

Thanks for the bug fixing.
The problem of the attribute table is solved but the other two issues (feature info and search widget) related to the widget "Value Relation" seem to persist.

Step to reproduce:

  • upload the demo project and data
  • query the "buildings" layer with the "QUERY LAYER" button: the expected values (A1, A2, B1, ...) of the field called "Subtype - Dependent on the value of Type" are displayed (see figure 1 - left);
  • query the "buildings" layer with the "QUERY BBOX LAYER" button: the unexpected keys (1, 2, 3, ...) of the field called "Subtype - Dependent on the value of Type" are displayed (see figure 1 - right). The same unexpected behavior occurs with the other two buttons "QUERY BY POLYGON" and "QUERY BY DRAW POLYGON";

image
Figure 1

  • open the "SEARCH WIDGET", select the "Subtype - Dependent on the value of Type" field and click the "ALL" button: the unexpected keys (and not the expected values) are shown and used for the search (see figure 2);

image
Figure 2

Can this ticket be reopened or should a new one be added?
Thanks in advance

Environment

  • g3w-admin: 3.6.dev-20230817135708
  • g3w-client: 3.9.0-alpha.0
  • browser: Firefox 116.0
  • operating system: Ubuntu 64-bit

@wlorenzetti
Copy link
Member

wlorenzetti commented Aug 18, 2023

Hi @gisuser0 , I fixed filter on attribute table, for fix QUERY BBOX LAYER QUERY BY POLYGON and QUERY BY DRAW POLYGON are not fixed, I have to make a qgis-plugin filter for WFS requests.
Github action close the issue, but it was wrong I reopen the issue.

@wlorenzetti wlorenzetti reopened this Aug 18, 2023
@wlorenzetti
Copy link
Member

Querybuilder is correct because work with raw layer data.

@wlorenzetti wlorenzetti modified the milestones: v3.7, v3.8 Nov 30, 2023
@gisuser0
Copy link
Author

gisuser0 commented Apr 19, 2024

The problem related to the widget "Value Relation" seems to persist.

Step to reproduce:

  1. upload the demo project and data
  2. query the "buildings" layer with the "QUERY LAYER" button: the expected values (A1, A2, B1, ...) of the field called "Subtype - Dependent on the value of Type" are displayed (see left figure);
  3. query the "buildings" layer with the "QUERY BBOX LAYER" button: the unexpected keys (1, 2, 3, ...) of the field called "Subtype - Dependent on the value of Type" are displayed (see right figure). The same unexpected behavior occurs with the other two buttons "QUERY BY POLYGON" and "QUERY BY DRAW POLYGON";
  4. the issue is also visible on the field "Address": the expected value is displayed using the "QUERY LAYER" button and the unexpected key is shown using the "QUERY BY POLYGON" button;

image


Environment

  • g3w-admin: 3.8.dev-20240419104028
  • g3w-client: 3.10.0-alpha.1
  • qtimeseries: undefined
  • browser: Firefox 125.0
  • operating system: Ubuntu 64-bit

Can this ticket be reopened or should a new one be added?
Thanks in advance

@Raruto
Copy link
Contributor

Raruto commented Apr 22, 2024

Maybe a @wlorenzetti oversight in #575 (comment).

@gisuser0 wasn't referring to the QueryBuilder panel, but instead to the following map controls:

QUERY LAYER

image

QUERY BY BBOX

image

[g3wsdk.info]

  • g3w-admin: 3.8.g3w-client_PR574-20240418060904
  • g3w-client: 3.10.0-alpha.2
    • qplotly: undefined
    • qtimeseries: undefined
  • browser: Chrome 123.0.0.0
  • operating system: Windows 10 64-bit

@Raruto Raruto reopened this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants