Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertex Tool: continue editing other vertices after moving a vertex #143

Closed
1 task done
verte-xi opened this issue Jan 22, 2025 · 14 comments · Fixed by #144
Closed
1 task done

Vertex Tool: continue editing other vertices after moving a vertex #143

verte-xi opened this issue Jan 22, 2025 · 14 comments · Fixed by #144
Assignees
Labels
feature New feature or request
Milestone

Comments

@verte-xi
Copy link

verte-xi commented Jan 22, 2025

Checklist

  • I've searched through the existing issues and this bug has never been reported before

Subject of the issue

After moving one vertex of a polygon, the feature gets deselected automatically. To continue editing other vertices, I have to reselect the polygon, which disrupts the workflow.

Image

Steps to reproduce

  1. Open a polygon layer for editing.
  2. Select a polygon and move one of its vertices using the vertex editing tool.
  3. Observe that after moving the vertex, the polygon feature is deselected automatically.
  4. To move another vertex, the polygon needs to be reselected.

Environment

[g3wsdk.info]

  • g3w-admin: 3.9.dev-20250122102828
  • g3w-client: 3.11.0-esbuild
    • editing: 3.9.0-esbuild
    • qplotly: 3.9.0
    • qtimeseries: 3.9.0
  • browser: Firefox 134.0
  • operating system: Windows 10 64-bit

Link to your project

https://dev.g3wsuite.it/en/map/g3w-suite-demo/qdjango/97/#

Additional info

Note: I am unsure if this issue originates from g3w-admin or g3w-client.

@verte-xi verte-xi added the bug Something isn't working label Jan 22, 2025
@volterra79 volterra79 transferred this issue from g3w-suite/g3w-admin Jan 22, 2025
@volterra79 volterra79 self-assigned this Jan 22, 2025
@volterra79 volterra79 added feature New feature or request and removed bug Something isn't working labels Jan 22, 2025
@volterra79 volterra79 added this to the 3.9 milestone Jan 22, 2025
@volterra79
Copy link
Member

@verte-xi is not an issue. This is the current behavior. Need to plan to improve it. Thanks

@verte-xi
Copy link
Author

Additionally, I tried using Google Chrome in Incognito mode, and editing does not work at all in this scenario. I did not see any direct errors in the browser console, but in the network requests, no feature requests are being shown.

[g3wsdk.info]

  • g3w-admin: 3.9.dev-20250122102828
  • g3w-client: 3.11.0-esbuild
    • editing: 3.9.0-esbuild
    • qplotly: 3.9.0
    • qtimeseries: 3.9.0
  • browser: Chrome 132.0.0.0
  • operating system: Windows 10 64-bit

Image

@volterra79
Copy link
Member

volterra79 commented Jan 22, 2025

@verte-xi can you try now?

@verte-xi
Copy link
Author

@volterra79 same again!
Also when attempting to create a feature using the "Create Feature" tool, snapping functionality is not working, and the feature geometry does not appear in the map for snapping.

I created a video demonstrating the issue, but I am unable to upload it directly to GitHub. Please let me know how I can share it for better clarity.

@volterra79
Copy link
Member

volterra79 commented Jan 22, 2025

@verte-xi Use CTRL+F5 to force to get fresh client libraries

@verte-xi
Copy link
Author

verte-xi commented Jan 22, 2025

@volterra79 I have converted the video to a GIF format. I hope the quality is sufficient to demonstrate the issue clearly.

Image

@volterra79
Copy link
Member

volterra79 commented Jan 22, 2025

@verte-xi No features are editable because are locked by another user.

When editing layer start on map, features, if load, will be same color that layer editing toolbox.

Wait 5 minutes and try again, after I unlock these features.

@volterra79
Copy link
Member

@verte-xi try now

@verte-xi
Copy link
Author

verte-xi commented Jan 22, 2025

@volterra79 now it works! thnx

@Raruto Raruto changed the title Polygon Feature Deselects After Moving a Vertex in v3.9.0 Vertex Tool: continue editing other vertices after moving a vertex Jan 23, 2025
@volterra79
Copy link
Member

@verte-xi can you check now https://dev.g3wsuite.it/en/map/g3w-suite-demo/qdjango/97/# about multi change vertex?
The PR is #144

@verte-xi
Copy link
Author

@verte-xi can you check now https://dev.g3wsuite.it/en/map/g3w-suite-demo/qdjango/97/# about multi change vertex? The PR is #144

@volterra79 Now everything works. What I would suggest is, when the user checks the "Snap Layer," it would be good to add one more checkbox to make the feature (geometry) display vertices of other features in a different style from the selected editing feature.

In this way, if the user wants to see the vertices of other features, they can simply check the box.

@volterra79
Copy link
Member

volterra79 commented Jan 28, 2025

@verte-xi can you check now https://dev.g3wsuite.it/en/map/g3w-suite-demo/qdjango/97/# about multi change vertex? The PR is #144

@volterra79 Now everything works. What I would suggest is, when the user checks the "Snap Layer," it would be good to add one more checkbox to make the feature (geometry) display vertices of other features in a different style from the selected editing feature.

In this way, if the user wants to see the vertices of other features, they can simply check the box.

@verte-xi try now and let me know. Thanks. I have to fix a bug. Just know if the flow is ok.

@volterra79 volterra79 reopened this Jan 29, 2025
@volterra79
Copy link
Member

@verte-xi i reopen it because i found a bug. I let you know

@verte-xi
Copy link
Author

@volterra79 U have right, i just tried again and editing isnt available yet, maybe can be from Editing LOCK (in past version was notification if some of feature was in Editing mode (locked) in extent view)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants