Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade X2JS from v1.2.0 to v3.4.4 #360

Open
1 task done
Raruto opened this issue Feb 27, 2023 · 0 comments
Open
1 task done

Upgrade X2JS from v1.2.0 to v3.4.4 #360

Raruto opened this issue Feb 27, 2023 · 0 comments
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@Raruto
Copy link
Collaborator

Raruto commented Feb 27, 2023

Checklist

  • I've searched through the current issues to make sure this feature hasn't been requested already.

Motivation

As per v3.8,


It's not so clear what is the currently installed version of x2js, as you can see there are three files uploaded in the src/assets/vendors/x2js folder:


There also seems to be a bug related to the parsing of queried coordinates (click on the map) on Firefox browsers:

image

XML Parsing Error: syntax error
Location: http://localhost:8000/en/map/buildings/qdjango/10/
Line Number 1, Column 1:

Related to: #356 (comment) and #356 (comment)

Suggested solution

Since I guess the current installed version could be v1.2.0:

var VERSION = "1.2.0";

I hope that updating that dependency to the latest available (ie. v3.4.4) will fix firefox related bug as well:

var VERSION = "3.4.4";

For more info: x2js/x2js

Alternatives considered

Remove this static vendor assets as well and install them via npm? Related to: #290

@Raruto Raruto added the dependencies Pull requests that update a dependency file label Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants