Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: auto restart service #40

Closed
Frenzie opened this issue Aug 29, 2017 · 12 comments
Closed

FR: auto restart service #40

Frenzie opened this issue Aug 29, 2017 · 12 comments

Comments

@Frenzie
Copy link

Frenzie commented Aug 29, 2017

c4b42d0 disables the service completely if the app is temporarily locked out of drawing overlays due to installing or updating an app, or granting permissions.

Also see #39 (comment)

@gabm
Copy link
Owner

gabm commented Aug 29, 2017

I re-checked .. i don't think that this is the case for installing/uninstalling or updating apps?! that should work in any case without taking away the permissions?!

@gabm
Copy link
Owner

gabm commented Aug 29, 2017

Currently I have the feeling that its quite sensible to auto-deactivate TnT and force the user through the re-activation process. The problem is the missing user-interface, actually just disabling TnT as long as the permission is not granted would work technically, but there is no real way of comunicating to the user: "Hey, please give the permission back"..

Options that come to my mind are:

  1. displaying a toast on every rotation attempt saying: "I'm not showing u the TnT button, because I can't, please give me the permission back!"
  2. silently do nothing and query for permission on every rotation attempt and when we have the permission back, return to normal operation
  3. When permission-loss is detected, switch off TnT completly and force the user through the main menu

Do you have other options? what do you suggest?

@Frenzie
Copy link
Author

Frenzie commented Aug 29, 2017

I made a quick video on my Zenfone 2 with Android 6 to demonstrate (remove the .zip extension; it's just a video).

VID_20170829_124434.mp4.zip

@gabm
Copy link
Owner

gabm commented Aug 29, 2017

ok, thats indeed different on Android 6.. I see...though I'm worried about user interaction.. what would you suggest? @Frenzie

@licaon-kter what is your opinion?

@licaon-kter
Copy link
Contributor

Toast is fine.

@Frenzie
Copy link
Author

Frenzie commented Aug 29, 2017

I think a combination of options would be the most user-friendly if it's not too much trouble to implement.

Silently query for permission until you hit some arbitrary limit (e.g., 20 total tries, or exceeded 30s since first failed attempt), then display a toast.

@gabm
Copy link
Owner

gabm commented Aug 29, 2017

ok.. I'll have a look into the code and let you know...

@Frenzie
Copy link
Author

Frenzie commented Aug 29, 2017

Awesome, thanks! Btw, which version of Android did you test with?

@gabm
Copy link
Owner

gabm commented Aug 29, 2017

I'm always on the latest.. 7.1.2 i think - It seems this permission/overlay thing changed a lot between 6 and 7 ..

@gabm
Copy link
Owner

gabm commented Sep 1, 2017

Ok, I checked and it looks good to me, I'll release it soon, but it will be a bit delayed due to another feature...

@Frenzie
Copy link
Author

Frenzie commented Sep 1, 2017 via email

@gabm
Copy link
Owner

gabm commented Sep 4, 2017

that should be released with 2.8.0 .. may take a while till it lands in fdroid..

@gabm gabm closed this as completed Sep 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants