diff --git a/production/catalog/gaiac/src/command.cpp b/production/catalog/gaiac/src/command.cpp index 0541cacec04d..a83819c728f9 100644 --- a/production/catalog/gaiac/src/command.cpp +++ b/production/catalog/gaiac/src/command.cpp @@ -221,15 +221,6 @@ void describe_table(const string& name) cout << "Parent references:" << endl; output_parent_references.print(cout); cout << endl; -#ifdef DEBUG - // Hide FlatBuffers related content in release build. - { - cout << endl; - cout << "Binary FlatBuffers Schema (in hex):" << endl; - auto_transaction_t tx; - cout << gaia_table_t::get(table_id).binary_schema().data() << endl; - } -#endif } #ifdef DEBUG @@ -239,7 +230,7 @@ void generate_table_fbs(const string& name) gaia_id_t table_id = c_invalid_gaia_id; { auto_transaction_t tx; - for (auto table : gaia_table_t::list()) + for (auto& table : gaia_table_t::list()) { string table_name{table.name()}; string qualified_name{table.gaia_database().name()}; diff --git a/production/inc/gaia/direct_access/edc_array.hpp b/production/inc/gaia/direct_access/edc_array.hpp index b63147ef1050..bbc325d1ba4b 100644 --- a/production/inc/gaia/direct_access/edc_array.hpp +++ b/production/inc/gaia/direct_access/edc_array.hpp @@ -11,6 +11,8 @@ #include "gaia/direct_access/edc_object.hpp" +#include "gaia_internal/common/retail_assert.hpp" + namespace gaia { @@ -22,6 +24,8 @@ template class edc_vector_t { public: + edc_vector_t() = delete; + const T_type* data() const { return m_vector->data(); @@ -43,13 +47,14 @@ class edc_vector_t private: // Make the edc_object_t a friend so it can call the private vector constructor. - template + template friend struct edc_object_t; explicit edc_vector_t(const flatbuffers::Vector* vector_ptr) : m_vector(vector_ptr) { - static_assert(std::is_arithmetic::value, "Only support arrays of basic types."); + static_assert(std::is_arithmetic::value, "edc_vector_t only supports basic types!"); + common::retail_assert(vector_ptr != nullptr, "edc_vector_t does not support null-valued array pointers!"); }; const flatbuffers::Vector* m_vector;