Opt physics experience and opt physics unit test

packages/core/src/Engine.ts

@@ -53,6 +53,8 @@ export class Engine extends EventDispatcher {
   static _noDepthTextureMacro: ShaderMacro = ShaderMacro.getByName("ENGINE_NO_DEPTH_TEXTURE");
   /** @internal Conversion of space units to pixel units for 2D. */
   static _pixelsPerUnit: number = 100;
+  /** @internal */
+  static _physicalObjectsMap: Record<number, ColliderShape> = {};
 
   /** Input manager of Engine. */
   readonly inputManager: InputManager;
@@ -66,8 +68,6 @@ export class Engine extends EventDispatcher {
   /** @internal */
   _physicsInitialized: boolean = false;
   /** @internal */
-  _physicalObjectsMap: Record<number, ColliderShape> = {};
-  /** @internal */
   _nativePhysicsManager: IPhysicsManager;
   /* @internal */
   _hardwareRenderer: IHardwareRenderer;

packages/core/src/physics/CharacterController.ts

@@ -5,18 +5,21 @@ import { Collider } from "./Collider";
 import { PhysicsScene } from "./PhysicsScene";
 import { ControllerNonWalkableMode } from "./enums/ControllerNonWalkableMode";
 import { ColliderShape } from "./shape";
+import { deepClone } from "../clone/CloneManager";
 
 /**
  * The character controllers.
  */
 export class CharacterController extends Collider {
-  private _stepOffset: number = 0.5;
+  private _stepOffset = 0.5;
   private _nonWalkableMode: ControllerNonWalkableMode = ControllerNonWalkableMode.PreventClimbing;
+  @deepClone
   private _upDirection = new Vector3(0, 1, 0);
-  private _slopeLimit: number = 0.707;
+  private _slopeLimit = 0.707;
 
   /**
    * The step offset for the controller.
+   * @remarks Character can overcome obstacle less than the height(stepOffset + contractOffset(0.1)).
    */
   get stepOffset(): number {
     return this._stepOffset;
@@ -57,7 +60,8 @@ export class CharacterController extends Collider {
   }
 
   /**
-   * The slope limit for the controller.
+   * The slope limit for the controller, the value is the cosine value of the maximum slope angle.
+   * @defaultValue 0.707(the cosine value of 45 degrees)
    */
   get slopeLimit(): number {
     return this._slopeLimit;
@@ -110,15 +114,6 @@ export class CharacterController extends Collider {
     this._updateFlag.flag = true;
   }
 
-  /**
-   * Remove all shape attached.
-   */
-  override clearShapes(): void {
-    if (this._shapes.length > 0) {
-      super.removeShape(this._shapes[0]);
-    }
-  }
-
   /**
    * @internal
    */
@@ -148,24 +143,22 @@ export class CharacterController extends Collider {
    * @internal
    */
   override _onEnableInScene() {
-    const physics = this.scene.physics;
-    physics._addCharacterController(this);
-    const shapes = this.shapes;
-    for (let i = 0, n = shapes.length; i < n; i++) {
-      physics._addColliderShape(shapes[i]);
-    }
+    this.scene.physics._addCharacterController(this);
   }
 
   /**
    * @internal
    */
   override _onDisableInScene() {
-    const physics = this.scene.physics;
-    physics._removeCharacterController(this);
-    const shapes = this.shapes;
-    for (let i = 0, n = shapes.length; i < n; i++) {
-      physics._removeColliderShape(shapes[i]);
-    }
+    this.scene.physics._removeCharacterController(this);
+  }
+
+  protected override _syncNative(): void {
+    super._syncNative();
+    (<ICharacterController>this._nativeCollider).setStepOffset(this._stepOffset);
+    (<ICharacterController>this._nativeCollider).setNonWalkableMode(this._nonWalkableMode);
+    (<ICharacterController>this._nativeCollider).setUpDirection(this._upDirection);
+    (<ICharacterController>this._nativeCollider).setSlopeLimit(this._slopeLimit);
   }
 
   private _syncWorldPositionFromPhysicalSpace(): void {

packages/core/src/physics/Collider.ts

@@ -50,11 +50,8 @@ export class Collider extends Component implements ICustomClone {
       if (oldCollider) {
         oldCollider.removeShape(shape);
       }
-
       this._shapes.push(shape);
-      shape._collider = this;
-      this._nativeCollider.addShape(shape._nativeShape);
-      this._phasedActiveInScene && this.scene.physics._addColliderShape(shape);
+      this._addNativeShape(shape);
     }
   }
 
@@ -66,9 +63,7 @@ export class Collider extends Component implements ICustomClone {
     const index = this._shapes.indexOf(shape);
     if (index !== -1) {
       this._shapes.splice(index, 1);
-      this._phasedActiveInScene && this.scene.physics._removeColliderShape(shape);
-      shape._collider = null;
-      this._nativeCollider.removeShape(shape._nativeShape);
+      this._removeNativeShape(shape);
     }
   }
 
@@ -79,9 +74,7 @@ export class Collider extends Component implements ICustomClone {
     const shapes = this._shapes;
     for (let i = 0, n = shapes.length; i < n; i++) {
       const shape = shapes[i];
-      this._phasedActiveInScene && this.scene.physics._removeColliderShape(shape);
-      shape._destroy();
-      this._nativeCollider.removeShape(shape._nativeShape);
+      this._removeNativeShape(shape);
     }
     shapes.length = 0;
   }
@@ -114,33 +107,26 @@ export class Collider extends Component implements ICustomClone {
    * @internal
    */
   override _onEnableInScene(): void {
-    const physics = this.scene.physics;
-    physics._addCollider(this);
-    const shapes = this.shapes;
-    for (let i = 0, n = shapes.length; i < n; i++) {
-      physics._addColliderShape(shapes[i]);
-    }
+    this.scene.physics._addCollider(this);
   }
 
   /**
    * @internal
    */
   override _onDisableInScene(): void {
-    const physics = this.scene.physics;
-    physics._removeCollider(this);
-    const shapes = this.shapes;
-    for (let i = 0, n = shapes.length; i < n; i++) {
-      physics._removeColliderShape(shapes[i]);
-    }
+    this.scene.physics._removeCollider(this);
   }
 
   /**
    * @internal
    */
   _cloneTo(target: Collider): void {
-    const shapes = target._shapes;
-    for (let i = 0, n = shapes.length; i < n; i++) {
-      target._addPhysicsShape(shapes[i]);
+    target._syncNative();
+  }
+
+  protected _syncNative(): void {
+    for (let i = 0, n = this.shapes.length; i < n; i++) {
+      this._addNativeShape(this.shapes[i]);
     }
   }
 
@@ -149,14 +135,23 @@ export class Collider extends Component implements ICustomClone {
    */
   protected override _onDestroy(): void {
     super._onDestroy();
-    this.clearShapes();
+    const shapes = this._shapes;
+    for (let i = 0, n = shapes.length; i < n; i++) {
+      const shape = shapes[i];
+      this._removeNativeShape(shape);
+      shape._destroy();
+    }
+    shapes.length = 0;
     this._nativeCollider.destroy();
   }
 
-  protected _addPhysicsShape(shape: ColliderShape): void {
+  protected _addNativeShape(shape: ColliderShape): void {
     shape._collider = this;
-
     this._nativeCollider.addShape(shape._nativeShape);
-    this._phasedActiveInScene && this.scene.physics._addColliderShape(shape);
+  }
+
+  protected _removeNativeShape(shape: ColliderShape): void {
+    shape._collider = null;
+    this._nativeCollider.removeShape(shape._nativeShape);
   }
 }